Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): static run one lifecycle should always print dependent task status, and output when verbose #21720

Merged
merged 4 commits into from Feb 9, 2024

Conversation

JamesHenry
Copy link
Collaborator

@JamesHenry JamesHenry commented Feb 8, 2024

Current Behavior

There is no output at all from dependent tasks when running one task with CI=true or --verbose when they are cache hits.

Expected Behavior

You always see dependent task statuses when running one task with CI=true or --verbose. You additionally see the full terminal outputs of cached dependent tasks when running with --verbose but not when only CI=true

E.g. foo -> bar, and build dependsOn ^build

Before (--verbose) - No evidence of bar's build at all (you don't even know the task name)

image

After (--verbose) - See the name of the task, its status, and its full terminal output

image

Before (CI=true) - No evidence of bar's build at all (you don't even know the task name)

image

After (CI=true) - See the name of the task and its status

image

@JamesHenry JamesHenry requested a review from a team as a code owner February 8, 2024 16:59
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 9, 2024 6:51pm

@JamesHenry JamesHenry changed the title fix(core): static run one lifecycle should always print dependent task outputs fix(core): static run one lifecycle should always print dependent task status, and output when verbose Feb 8, 2024
@JamesHenry JamesHenry enabled auto-merge (squash) February 8, 2024 20:01
@JamesHenry JamesHenry merged commit 5911ca6 into nrwl:master Feb 9, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 9, 2024
…k status, and output when verbose (#21720)

(cherry picked from commit 5911ca6)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
@JamesHenry JamesHenry deleted the static-run-one-terminal-outputs branch February 19, 2024 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants