Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playwright): fix include in tsconfig.json #21730

Merged
merged 1 commit into from Feb 9, 2024

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Feb 8, 2024

Current Behavior

currently, tsconfig.json for playwright looks like this:

  "include": [
    "**/*.ts",
    "**/*.js",
    "../playwright.config.ts",
    "../**/*.spec.ts",
    "../**/*.spec.js",
    "../**/*.d.ts"
  ]

tsconfig.json is at project level and in same folder of playwright.config.ts, so the include paths don't seem to be correctly.

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner February 8, 2024 21:06
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 10:01pm

@xiongemi xiongemi force-pushed the fix/fix-vite-ts-config-include branch from bb884d3 to 85d69cd Compare February 9, 2024 22:00
@FrozenPandaz FrozenPandaz merged commit 27faa7d into nrwl:master Feb 9, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Feb 9, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants