Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): pin generated vite version to ~5.0.0 to avoid issues with storybook #21740

Merged
merged 1 commit into from Feb 9, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 9, 2024

Current Behavior

The recently released Vite 5.1.0 (and 5.1.1 released afterward) causes Storybook builds to fail with an error like:

e2e-nuxt: => Failed to build the preview
e2e-nuxt: Error: Unexpected early exit. This happens when Promises returned by plugins cannot resolve. Unfinished hook action(s) on exit:
e2e-nuxt: (vite:esbuild) transform "./.storybook/preview.ts"
e2e-nuxt: (vite:esbuild) transform "./src/components/NxWelcome.stories.ts"
e2e-nuxt: (vite:esbuild) transform "./src/components/one/one.stories.ts"

Expected Behavior

Storybook builds with Vite should work. The generated Vite version is restricted to ~5.0.0 to prevent issues until they are fixed.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 9, 2024
Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 9, 2024 11:39am

@leosvelperez leosvelperez changed the title chore(repo): test ci fix(misc): pin generated vite version to ~5.0.0 to avoid issues with storybook Feb 9, 2024
@leosvelperez leosvelperez marked this pull request as ready for review February 9, 2024 13:01
@leosvelperez leosvelperez requested review from a team as code owners February 9, 2024 13:01
@jaysoo jaysoo merged commit d2272fd into nrwl:master Feb 9, 2024
6 checks passed
@leosvelperez leosvelperez deleted the ci/test branch February 9, 2024 13:16
FrozenPandaz pushed a commit that referenced this pull request Feb 9, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants