Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(release): do not stop daemon in dry-run #21743

Merged
merged 3 commits into from Feb 9, 2024
Merged

fix(release): do not stop daemon in dry-run #21743

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
688f17a
fix(release): do not stop daemon in dry-run
JamesHenry Feb 9, 2024
977c124
Merge branch 'master' into release-lock-file-fix
JamesHenry Feb 9, 2024
136c4cd
Merge branch 'master' into release-lock-file-fix
JamesHenry Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/js/src/generators/release-version/utils/update-lock-file.ts
View file
Open in desktop
Expand Up @@ -47,8 +47,8 @@ export async function updateLockFile(
}

const isDaemonEnabled = daemonClient.enabled();
if (isDaemonEnabled) {
// temporarily stop the daemon, as it will error if the lock file is updated
if (!dryRun && isDaemonEnabled) {
// if not in dry-run temporarily stop the daemon, as it will error if the lock file is updated
await daemonClient.stop();
}

Expand Down