Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): skip prompt for publish when no version created #21769

Merged
merged 1 commit into from Feb 12, 2024

Conversation

edbzn
Copy link
Contributor

@edbzn edbzn commented Feb 10, 2024

Current Behavior

Running nx release prompt "Do you want to publish these versions?" even if no version was created during the process.

Expected Behavior

Skip prompt and publish if no version was created.

Related Issue(s)

N/A

@edbzn edbzn requested a review from a team as a code owner February 10, 2024 17:45
Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 2:49pm

@JamesHenry
Copy link
Collaborator

Thanks @edbzn! The e2e failure should hopefully go away once you update to latest

@JamesHenry JamesHenry enabled auto-merge (squash) February 12, 2024 15:14
@JamesHenry JamesHenry merged commit ff143e4 into nrwl:master Feb 12, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants