fix(js): Adds mjs files to prettierrcNameOptions #21796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ppfenning92
changed the title
ppfenning92
changed the title
ppfenning92
changed the title
Adds missing file extension
ndcunningham
approved these changes
May 10, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
May 13, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> when running a generator, it does not check for the existence of a prettier.config.mjs or .prettierrc.mjs file ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> When using a generator, it check for the existence of all config file names specified in the docs. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #21795 adds .mjs file names to checks (cherry picked from commit 88ac601)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
when running a generator, it does not check for the existence of a prettier.config.mjs or .prettierrc.mjs file
Expected Behavior
When using a generator, it check for the existence of all config file names specified in the docs.
Related Issue(s)
Fixes #21795
adds .mjs file names to checks