Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): swc executor should support inlining on windows #21801

Merged
merged 1 commit into from Feb 13, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 13, 2024

Current Behavior

@nx/js:swc executor does not support inlining on Windows due to file path issues

Expected Behavior

Support windows for swc inlining

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner February 13, 2024 15:49
@Coly010 Coly010 self-assigned this Feb 13, 2024
@Coly010 Coly010 requested a review from jaysoo February 13, 2024 15:49
Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2024 4:14pm

@Coly010 Coly010 merged commit 972801e into nrwl:master Feb 13, 2024
6 checks passed
@Coly010 Coly010 deleted the js/fix-swc-executor-win branch February 13, 2024 18:48
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants