Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support migrating to canary versions of nx for testing #21812

Merged
merged 1 commit into from Feb 15, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 14, 2024

Current Behavior

Running nx migrate canary doesn't migrate projects to nx@canary. It also installs nx@latest in a temp dir to run the command and there's no way to force that installation to use the canary version.

Expected Behavior

Running nx migrate canary should migrate projects to nx@canary. Providing the NX_MIGRATE_CLI_VERSION will allow installing a custom version of nx in a temp dir to run the command.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 14, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner February 14, 2024 16:02
Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 15, 2024 10:20am

@leosvelperez leosvelperez requested a review from a team as a code owner February 15, 2024 10:15
@leosvelperez leosvelperez changed the title feat(core): support migrating to a canary version of nx for testing feat(core): support migrating to canary versions of nx for testing Feb 15, 2024
@leosvelperez leosvelperez merged commit 2b7047b into nrwl:master Feb 15, 2024
6 checks passed
@leosvelperez leosvelperez deleted the core/nx-migrate-canary branch February 15, 2024 15:45
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
@mandarini
Copy link
Member

nx migrate canary still does not work

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants