Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): prompt to create github release when no file changes #21819

Merged
merged 6 commits into from Feb 21, 2024

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 14, 2024

Current Behavior

Nx Release exits with a warning when changelog files and github releases are enabled and there are no changelog file changes. This means that there is no way to update a remote github release if the local changelog file is already up to date.

Expected Behavior

When changelog files and github releases are enabled and there are no changelog file changes, the end user is prompted to see if they want to create a github release anyway. This allows users to update a remote github release regardless of the state of a local changelog file, like in the case where the remote release was updated in the github UI.

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 21, 2024 4:14pm

@fahslaj fahslaj marked this pull request as ready for review February 15, 2024 00:28
@fahslaj fahslaj requested a review from a team as a code owner February 15, 2024 00:28
@fahslaj fahslaj merged commit 2054827 into nrwl:master Feb 21, 2024
6 checks passed
@fahslaj fahslaj deleted the feat/force-create-github-release branch February 21, 2024 18:01
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants