Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Update NxWelcome connect to cloud #21830

Merged
merged 1 commit into from Feb 15, 2024

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

Update the command to connect to cloud inside NxWelcome to be nx-connect
Screenshot 2024-02-13 at 3 28 32 PM

Expected Behavior

Currently, the command is nx connect-to-nx-cloud

Screenshot 2024-02-15 at 12 13 12 PM

@ndcunningham ndcunningham self-assigned this Feb 15, 2024
@ndcunningham ndcunningham requested review from a team and Coly010 as code owners February 15, 2024 19:14
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 15, 2024 7:29pm

@ndcunningham ndcunningham force-pushed the fix/nx-welcome-update-cloud-command branch from 0895364 to ff84ac3 Compare February 15, 2024 19:28
Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were also discussing the onboarding, whether nx connect still makes sense here or not. Maybe it's a follow-up for later?

@ndcunningham ndcunningham merged commit 97e60f3 into master Feb 15, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/nx-welcome-update-cloud-command branch February 15, 2024 19:57
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants