Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): typo in tsconfig.spec.json update led to invalid tsconfig #21886

Merged
merged 1 commit into from Feb 20, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 20, 2024

Current Behavior

There was a typo when updating the includes option in the tsconfig.spec.json which led to an invalid TsConfig.
This resulted in type errors in the test files.

Expected Behavior

Test files should not have type errors.

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner February 20, 2024 11:37
Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2024 11:38am

@Coly010 Coly010 self-assigned this Feb 20, 2024
@mandarini mandarini merged commit 246fd19 into nrwl:master Feb 20, 2024
6 checks passed
@Coly010 Coly010 deleted the remix/fix-tsconfig-spec-gen branch February 20, 2024 14:36
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants