Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): surface original error when remotes fail to start #21919

Merged
merged 1 commit into from Feb 21, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 21, 2024

When serving federated host and remote apps, the error from remote serve is swallowed. This prevents further debugging if the error is unexpected.

Current Behavior

Original error is not swallowed.

Expected Behavior

Original error should be shown.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Feb 21, 2024 4:17pm

@jaysoo jaysoo merged commit 317ef2e into master Feb 21, 2024
6 checks passed
@jaysoo jaysoo deleted the mf_error_cause branch February 21, 2024 18:31
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants