fix(react): ensure playwright configuration is using correct port in app gen #21941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6d56b7b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
module-federation/react-playwright
branch
3 times, most recently
from
61f2bb7
to
917ac8e
Compare
Coly010
force-pushed
the
module-federation/react-playwright
branch
from
917ac8e
to
6d56b7b
Compare
mandarini
approved these changes
Feb 23, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When selecting playwright as the e2e test runner for module federation applications it generates an incorrect playwright config.
It only points at :4200 which will be incorrect for remote applications.
This causes playwright to wait for a dev server port to open which will never open.
Expected Behavior
Use the correct port in app gen when configuring playwright to allow for successful e2e setup.
Related Issue(s)
Fixes #