fix(testing): ensure baseUrl is not passed to playwright cli #21943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 72b739c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
playwright/remove-invalid-options
branch
from
415dcbd
to
72c51ef
Compare
leosvelperez
requested changes
Feb 22, 2024
packages/playwright/src/executors/playwright/playwright.impl.ts
Outdated
Show resolved
Hide resolved
packages/playwright/src/migrations/update-18-1-0/remove-baseUrl-from-project-json.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
playwright/remove-invalid-options
branch
from
72c51ef
to
6385a6e
Compare
Coly010
force-pushed
the
playwright/remove-invalid-options
branch
from
6385a6e
to
72b739c
Compare
leosvelperez
approved these changes
Feb 22, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Playwright does not support
--base-urlas a CLI argument.Some of our generators have generated
baseUrlas an option to the@nx:/playwright:playwrightexecutor.When executed, this causes an error.
Expected Behavior
Ensure that
baseUrldoes not get added to the CLI args if it exists in the project.jsonAdd a migration to remove
baseUrlif it already exists in the project.jsonRelated Issue(s)
Fixes #