fix(core): plugin pool should not clobber promises when called multiple times #21977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b3bedce. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
AgentEnder
force-pushed
the
fix/plugin-pool-tx-id
branch
from
8f739cd
to
a32b21e
Compare
AgentEnder
force-pushed
the
fix/plugin-pool-tx-id
branch
from
a32b21e
to
1a06066
Compare
Cammisuli
approved these changes
Feb 27, 2024
AgentEnder
force-pushed
the
fix/plugin-pool-tx-id
branch
from
1a06066
to
0246d9d
Compare
AgentEnder
force-pushed
the
fix/plugin-pool-tx-id
branch
from
0246d9d
to
b3bedce
Compare
|
Only failing test is remix e2e - going to admin merge. We need to investigate the remix e2e further. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Plugin Pool / Plugin worker exhibits some weird behavior in following cases:
Expected Behavior
Promises are resolved by proper result message and we wait for pending promises before killing the workers.
Related Issue(s)
Fixes #