Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): nextjs-standalone generates package scripts consistent with create-next-app #21996

Merged
merged 1 commit into from Feb 29, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Feb 26, 2024

This PR fixes the package scripts generated by create-nx-workspace when picking the Next.js standalone option.

The scripts should be the same as running create-next-app then running nx init.

"scripts": {
    "dev": "nx dev",
    "build": "nx build",
    "start": "nx start"
}

Current Behavior

npm start fails since nx serve is not a target for Next.js.

Expected Behavior

npm start runs the production server, and npm run dev runs the devserver.

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner February 26, 2024 14:27
Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 6:23pm

@jaysoo jaysoo force-pushed the fix_next_root_script branch 2 times, most recently from 7c3234d to b2b07b8 Compare February 29, 2024 13:15
@jaysoo jaysoo merged commit 58cfaae into master Feb 29, 2024
6 checks passed
@jaysoo jaysoo deleted the fix_next_root_script branch February 29, 2024 19:49
jaysoo added a commit that referenced this pull request Feb 29, 2024
Copy link

github-actions bot commented Mar 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants