Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graph): add error boundary error page for project details #22007

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Feb 27, 2024

Current Behavior

no error page for project details view when killed graph

Expected Behavior

Screenshot 2024-03-01 at 4 21 15 PM Screenshot 2024-03-01 at 4 21 53 PM

Related Issue(s)

Fixes #

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 5, 2024 5:24pm

Copy link
Collaborator

@MaxKless MaxKless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • small rewording
  • we should take light / dark mode into consideration. Right now if you're in dark mode, the error page is rendered in light mode which is kind of jarring

Otherwise it looks good :)

graph/client/src/app/ui-components/error-boundary.tsx Outdated Show resolved Hide resolved
@xiongemi xiongemi force-pushed the feature/nxp-627-better-error-message-in-pdv branch from f213d6e to 91416e2 Compare March 5, 2024 17:19
@FrozenPandaz FrozenPandaz merged commit a3ef2c6 into nrwl:master Mar 5, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants