Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): make sure to add e2e crystal plugin #22041

Merged
merged 1 commit into from Feb 29, 2024

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Feb 28, 2024

  • opts.addPlugin ??= process.env.NX_ADD_PLUGINS !== 'false'; was missing from a couple of places
  • this resulted in also React not setting up cypress with Crystal
  • If Nx detected cypress was already installed, it would not add the plugin, even if the addPlugin was true
  • Playwright was not being set for Vue also because we were not passing the options.addPlugin down to the playwright config generator

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 29, 2024 2:22pm

@mandarini mandarini merged commit 5971ae1 into nrwl:master Feb 29, 2024
6 checks passed
Copy link

github-actions bot commented Mar 6, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants