Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): Add e2e-ci and serve-static targets #22056

Merged
merged 1 commit into from Feb 28, 2024

Conversation

ndcunningham
Copy link
Contributor

Add missing targets for nuxt.

@ndcunningham ndcunningham self-assigned this Feb 28, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner February 28, 2024 19:58
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 28, 2024 8:45pm

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is build-static different from build? I thought build was already static.

docs/generated/packages/nuxt/documents/overview.md Outdated Show resolved Hide resolved
docs/shared/packages/nuxt/nuxt-plugin.md Outdated Show resolved Hide resolved
@ndcunningham
Copy link
Contributor Author

ndcunningham commented Feb 28, 2024

How is build-static different from build? I thought build was already static.

It requires the nuxt serve to run. i.e. no static files are generated build-static runs nuxt build --prerender that creates statics files inside the {projectRoot}/dist. I can add this to the documentation as well to make it more clear

@isaacplmann
Copy link
Collaborator

Yeah, if you explain what build-static is in the docs, that would be helpful.

@ndcunningham ndcunningham merged commit 287a0e0 into master Feb 28, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/nuxt-add-serve-static branch February 28, 2024 20:53
Copy link

github-actions bot commented Mar 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants