Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): plugins should not be registered twice and should respect shutdown queue #22057

Merged
merged 1 commit into from Feb 28, 2024

Conversation

AgentEnder
Copy link
Member

Fixes two issues:

  • Plugins could be registered twice if first one is not finished loading when called second time
  • Plugin worker shutdown didn't properly listen to plugin events

@AgentEnder AgentEnder requested a review from a team as a code owner February 28, 2024 20:29
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 8:38pm

@AgentEnder AgentEnder force-pushed the fix/plugins-hanging-on-shutdown branch from 20403ac to 5f5b647 Compare February 28, 2024 20:34
@AgentEnder AgentEnder force-pushed the fix/plugins-hanging-on-shutdown branch from 5f5b647 to 9f14540 Compare February 28, 2024 20:37
@AgentEnder AgentEnder merged commit 9efde91 into nrwl:master Feb 28, 2024
4 of 6 checks passed
@AgentEnder AgentEnder deleted the fix/plugins-hanging-on-shutdown branch February 28, 2024 22:38
Copy link

github-actions bot commented Mar 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants