Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): forward options for run command #22064

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Feb 29, 2024

Current Behavior

when the target is:

    "dev": {
      "options": {
        "port": 4200
      }
    }

it does not override the port

Expected Behavior

now it will override the command options, it will run dev with port 4200.

current behaviour is the same, when args is specified, it will take the args, it will run dev with port 4566.

  "dev": {
      "options": {
        "args": ["--port", "4566"],
        "port": 4200
      }
    }

or when running dev with flag passed in, like run nx dev ... --port 3300, it will take the port regardless what specified in project.json.

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from a team as a code owner February 29, 2024 05:11
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 8:45pm

@xiongemi xiongemi force-pushed the feature/nxc-359-how-to-forward-options-to-run-command-powered-crystal branch 5 times, most recently from 253dd00 to 442f630 Compare March 4, 2024 16:29
@xiongemi xiongemi force-pushed the feature/nxc-359-how-to-forward-options-to-run-command-powered-crystal branch from 442f630 to 06f7eb1 Compare March 4, 2024 20:44
@FrozenPandaz FrozenPandaz merged commit da5a19d into nrwl:master Mar 6, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants