Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): reject all promises in pool during shutdown #22188

Merged
merged 1 commit into from Mar 6, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

When shutdown is requested, we still await all the promises which may never complete.

Expected Behavior

When shutdown is requested, the pool will reject all promises so that the process exits.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 10:00pm

@FrozenPandaz FrozenPandaz marked this pull request as ready for review March 6, 2024 22:47
@FrozenPandaz FrozenPandaz requested a review from a team as a code owner March 6, 2024 22:47
@FrozenPandaz FrozenPandaz merged commit 84d96cc into nrwl:master Mar 6, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the fix-pool branch March 6, 2024 22:48
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Mar 8, 2024
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Mar 8, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants