Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Surface error codes when build is interrupted by signals SIGINT, SIGTERM etc... #22190

Merged
merged 1 commit into from Mar 7, 2024

Conversation

ndcunningham
Copy link
Contributor

When the nx/next:build executor is abruptly interrupted due to a signal such as SIGKILL we should surface these signals downstream so that they can be outputted to the console.

fixes: #22148

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Mar 6, 2024
@ndcunningham ndcunningham self-assigned this Mar 6, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner March 6, 2024 22:49
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Mar 6, 2024 10:49pm

@ndcunningham ndcunningham merged commit 466debe into master Mar 7, 2024
7 checks passed
@ndcunningham ndcunningham deleted the fix/next-build-exec-error-signals branch March 7, 2024 18:46
FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2024
… SIGINT, SIGTERM etc... (#22190)

(cherry picked from commit 466debe)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8s - Nx - Next
2 participants