Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): make windows runtime input hashing windowless #22197

Merged
merged 1 commit into from Mar 12, 2024

Conversation

axelstudios
Copy link
Contributor

Current Behavior

When runtime inputs are hashed on Windows it results in several command prompt popups

Expected Behavior

All subprocesses should be windowless

Related Issue(s)

Fixes #22194

@axelstudios axelstudios requested review from a team as code owners March 7, 2024 07:33
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 8, 2024 4:09pm

@please-rewrite
Copy link

This is currently the most frustrating issue with NX on Windows.
Please merge this @FrozenPandaz 🙏

@FrozenPandaz
Copy link
Collaborator

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 0025b3c into nrwl:master Mar 12, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime inputs result in visible command prompt popups on Windows
3 participants