Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): pass correct argument to rspack configuration generator #22241

Merged
merged 1 commit into from Mar 8, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Mar 8, 2024

Current Behavior

Calling incorrect property uiFramework when setting up rspack for react appliaction

Expected Behavior

Calling correct property framework when setting up rspack for react application

Related Issue(s)

Fixes #

@Coly010 Coly010 self-assigned this Mar 8, 2024
@Coly010 Coly010 requested a review from a team as a code owner March 8, 2024 16:58
@Coly010 Coly010 requested a review from jaysoo March 8, 2024 16:58
Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 8, 2024 4:59pm

@Coly010 Coly010 merged commit 8559993 into nrwl:master Mar 8, 2024
6 checks passed
@Coly010 Coly010 deleted the react/setup-rspack-correctly branch March 8, 2024 18:08
FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants