Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): Storing nxjson details too early #22285

Merged
merged 1 commit into from Mar 12, 2024
Merged

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Mar 12, 2024

If we store nx.json before the vite initGenerator updates it due to adding vite plugin to nx.json.

When we read it back to decide if we want to use inferred targets or not it will be outdated and produce the wrong result. (i.e. it will add targets to project.json even though we wanted to use inferred targets).

@ndcunningham ndcunningham self-assigned this Mar 12, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner March 12, 2024 17:45
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2024 5:53pm

@ndcunningham ndcunningham enabled auto-merge (squash) March 12, 2024 18:45
@ndcunningham ndcunningham merged commit b6cd196 into master Mar 12, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/vite-read-nx-json branch March 12, 2024 19:22
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants