fix(core): fix pty for multiple commands in 1 process #22294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bc7cbdd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
FrozenPandaz
force-pushed
the
fix-pty
branch
3 times, most recently
from
61d2604
to
a2e0004
Compare
4 tasks
FrozenPandaz
force-pushed
the
fix-pty
branch
4 times, most recently
from
545d5bc
to
9f70c7e
Compare
FrozenPandaz
force-pushed
the
fix-pty
branch
4 times, most recently
from
55b6ae6
to
35a790d
Compare
Cammisuli
approved these changes
Mar 15, 2024
This was referenced Mar 15, 2024
arekkubaczkowski
pushed a commit
to arekkubaczkowski/nx
that referenced
this pull request
Mar 19, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When multiple commands are run via the pseudo terminal, subsequent commands hang.
Expected Behavior
The pseudo terminal is able to run multiple commands without hanging.
Related Issue(s)
Fixes #21744
Fixes #21779
Fixes #22094
Fixes #21978
Fixes #21965