fix(core): do not use pseudo terminal if platform is unsuported and f… #22341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3cab3e7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Cammisuli
approved these changes
Mar 16, 2024
FrozenPandaz
force-pushed
the
fix-fork-task-runner
branch
from
a5ed2d2
to
3cab3e7
Compare
4 tasks
arekkubaczkowski
pushed a commit
to arekkubaczkowski/nx
that referenced
this pull request
Mar 19, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…or run-many
Current Behavior
Users will get an error if the pseudo terminal is used on an unsupported platform.
Also,
nx run-many --parallel 3will not work.Expected Behavior
There is a fallback for unsupported platforms
nx run-many --parallel 3will work.Related Issue(s)
Fixes #22235