feat(testing): make playwright default e2e test runner option #22511
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 15a2105. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
make-playwright-default
branch
from
a4f716e
to
7c11916
Compare
Coly010
force-pushed
the
make-playwright-default
branch
from
7c11916
to
cc3b6f9
Compare
Coly010
force-pushed
the
make-playwright-default
branch
2 times, most recently
from
f58afc3
to
83dbba6
Compare
Coly010
force-pushed
the
make-playwright-default
branch
from
83dbba6
to
83b72f9
Compare
|
@Coly010 I guess we should also default to the Playwright choice in the CNW prompt, isn't it? |
Coly010
force-pushed
the
make-playwright-default
branch
from
83b72f9
to
cd9ba5f
Compare
Coly010
added
the
target: next major version
There was a problem hiding this comment.
Do you think it would be worth adding a migration for current workspaces that already contain a cypress project that sets cypress as the default for the various generators inside nx.json#generators?
As is, I could see folks being upset if they have a repo with 5+ e2e apps using cypress, and suddenly this swaps to playwright.
|
@AgentEnder Those generatorDefaults should be set already when they chose I'm not sure what the "right" thing to do here would be because I can see people also wanting to actually use playwright but might have legacy cypress projects. I think it could be a case of having some kind of note in release notes, or wait and see the verdict from people after the change has been made. |
Coly010
force-pushed
the
make-playwright-default
branch
from
cd9ba5f
to
e191b1e
Compare
Coly010
removed
the
target: next major version
Coly010
force-pushed
the
make-playwright-default
branch
from
e191b1e
to
4561327
Compare
Coly010
force-pushed
the
make-playwright-default
branch
from
4561327
to
15a2105
Compare
| @@ -43,7 +43,7 @@ describe('React Module Federation', () => { | |||
| const defaultRemotePort = 4201; | |||
|
|
|||
| runCLI( | |||
| `generate @nx/react:host ${shell} --remotes=${remote1},${remote2},${remote3} --style=css --no-interactive --skipFormat --js=${js}` | |||
| `generate @nx/react:host ${shell} --remotes=${remote1},${remote2},${remote3} --e2eTestRunner=cypress --style=css --no-interactive --skipFormat --js=${js}` | |||
There was a problem hiding this comment.
How come these tests use cypress? Are there playwright ones elsewhere? Should these be playwright?
There was a problem hiding this comment.
They perform specific setup of .cy.ts files, it felt wrong to change and not have covered.
There was a problem hiding this comment.
There may need to be new e2e tests written specifically for playwright, i'll double check which are missing and address in follow up
| @@ -68,6 +68,7 @@ export async function addE2e(host: Tree, options: NormalizedSchema) { | |||
| root: options.e2eProjectRoot, | |||
| sourceRoot: joinPathFragments(options.e2eProjectRoot, 'src'), | |||
| targets: {}, | |||
| tags: [], | |||
There was a problem hiding this comment.
Why was this added? Can you fix this in a follow up PR please?
There was a problem hiding this comment.
It was failing without it. I can check again
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Cypress is set as the default e2e test runner
Expected Behavior
Playwright is set as the default e2e test runner
Related Issue(s)
Fixes #