fix(vite): handle both vite.config.ts and vitest.config.ts

[MaximeBernard]

Current Behavior

When a package has both vite.config.ts and vitest.config.ts, plugin fails to infer targets correctly (in my case, I had some packages with test targets, some with build targets).

Expected Behavior

Having both files should not bother nx plugin.

Related Issue(s)

Might fix #22244

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)	Visit Preview	Mar 27, 2024 1:12pm

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fd8c1c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=e2e,e2e-ci --base=35321615b208513a024ebf23df838e4f807e786d --head=fd8c1c8ec9949aeb7967f543cce96f83a5bb7b76 --parallel=1
• nx affected --targets=lint,test,build --base=35321615b208513a024ebf23df838e4f807e786d --head=fd8c1c8ec9949aeb7967f543cce96f83a5bb7b76 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=35321615b208513a024ebf23df838e4f807e786d --head=fd8c1c8ec9949aeb7967f543cce96f83a5bb7b76
• nx documentation --no-dte
• nx affected -t e2e-macos --parallel=1 --base=35321615b208513a024ebf23df838e4f807e786d --head=fd8c1c8ec9949aeb7967f543cce96f83a5bb7b76

---

Sent with 💌 from NxCloud.

[MaximeBernard]

For the record, the build was green before I rebased 😉

[MaximeBernard]

@AgentEnder since you recently worked on plugin configuration, maybe you could take a look at this PR?

[Coly010]

Closed in favour of: #22618

[MaximeBernard]

@Coly010 #22618 is a nice fix but my suggestion seems fair as well (at least for clarity). Unless I missed the point?

Anyway, thanks for the feedback and fixing the underlying issue. ❤️

[Coly010]

Hey @MaximeBernard!

Sorry, I should have elaborated more and I also should have said this: Thanks for the PR to attempt to fix this! 🎉

There are two things really.

1. The issue was less about how the targets are created.
I tried your example locally, and although on first run after the cache was reset all targets were created successfully, subsequent runs only had the build, serve, preview etc targets. It was missing test for example.

The real issue was not about the conditional on the config file name. It was because both config files were generating the same hash as the parameters were the same, which led to one or the other of the config files overwriting the cache for the targets. Which config file did this was dictated by that conditional. Changing it only changed which config file overwrote the cache last.

2. Code style
There are two conditionals that dictate the targets that should be created. From a personal perspective, I find it easier to read code that does something for the truthy and falsey outcomes of that same conditional.

IF configFile != vitest THEN
 // Add Build Targets etc
 
 IF configFile == vitest THEN
// Add Test Target

So when it comes to reading it, you get an overall picture of what happens when the config file is or is not vitest.

Perhaps your suggestion would be more clear, but it's just semantics at that stage.

All this said, thank you again for taking a stab at this! Your suggestion in this PR helped me to identify the root cause of the issue more swiftly!

[MaximeBernard]

Thank you so much for this answer ❤️

Agree with you it's more about semantic at this point.

In my case, I had 3 scenarios

• vite.config.ts
• vitest.config.ts
• vite.config.ts & vitest.config.ts

When I investigated, this seemed awkward because I didn't expect 2 "runs" (1 on each file).

Thank you for the clarification, have a great day 🚀

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.