fix(core): do not assume workspace inputs cause all projects to be af… #22573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
FrozenPandaz
force-pushed
the
fix-affected
branch
from
cd7895d
to
c1c3026
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c1c3026. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Apr 2, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fected
Current Behavior
When any named input of a project is touched, the project is affected. This happens even if the project has no targets which use that named input. For instance, if a named input for a fileset for e2e targets is touched, all projects even those with no e2e targets, are affected.
Expected Behavior
Affected projects are determined solely by the inputs which are used in their targets. In the example above, touching files in the fileset named for e2e targets will only affect projects with e2e targets.
Related Issue(s)
Fixes #21763