feat(bundling): upgrade rollup to v4 #22656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d442b33. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
rollup_upgrade
branch
2 times, most recently
from
e4ebb05
to
d3e208b
Compare
jaysoo
commented
Apr 18, 2024
| @@ -172,7 +174,7 @@ describe('Rollup Plugin', () => { | |||
| ); | |||
| updateFile(`libs/test/package.json`, JSON.stringify({ name: 'test' })); | |||
| updateFile( | |||
| `libs/test/rollup.config.js`, | |||
| `libs/test/rollup.config.mjs`, | |||
There was a problem hiding this comment.
Rollup v2 must have been doing something to process the file, but with v4 it is using Node resolution so the file must be .mjs or the workspace needs type: 'module' in package.json.
ndcunningham
approved these changes
Apr 18, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Rollup to v4, and updates necessary plugins to support the update. The previous
rollup-plugin-peer-deps-externalplugin is removed since it is no longer needed.We should wait until Nx 19 to merge this since this could be a breaking change if users have custom Rollup plugins that are incompatible with Rollup v4.
Changes:
@rollup/plugin-urland@svgr/rollupCurrent Behavior
Expected Behavior
Related Issue(s)
Fixes #22604