Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): add ability to split jest tests #22662

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat(testing): add ability to split jest tests #22662

merged 1 commit into from
Apr 10, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Apr 4, 2024 •
edited

Current Behavior

The @nx/jest/plugin does not split tasks like Cypress and Playwright.

Expected Behavior

The @nx/jest/plugin does split tasks like Cypress and Playwright. This is not enabled by default but can be enabled by configuring @nx/jest/plugin to have a ciTargetName.

This is not recommended for unit tests like jest is usually used for. If e2e tests are run via jest, like they are in the Nx repo, it can be enabled.

Related Issue(s)

Fixes #

@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 10, 2024 2:25pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 4, 2024 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e081de8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

AgentEnder
AgentEnder requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only real change request is the project-level metadata, otherwise looks good. I'd like a better description, but can't think of better phrasing so 🤷

packages/jest/src/plugins/plugin.spec.ts
},
],
"metadata": {
"description": "Run Jest Tests in CI",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this description should be a bit more... descriptive. It would be nice if it mentioned that running it prompts the split targets to be ran in some way.

packages/jest/src/plugins/plugin.ts Outdated
@@ -96,7 +91,7 @@ export const createNodes: CreateNodes<JestPluginOptions> = [
options = normalizeOptions(options);

const hash = calculateHashForCreateNodes(projectRoot, options, context);
const targets =
const { targets } =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should set the project-level metadata too

@FrozenPandaz FrozenPandaz force-pushed the jest-split branch 2 times, most recently from 9ea1b5e to 832ecc5 Compare April 10, 2024 13:21
@FrozenPandaz FrozenPandaz marked this pull request as ready for review April 10, 2024 17:08
Coly010
Coly010 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the Remix e2e, LGTM

@FrozenPandaz FrozenPandaz merged commit fd7cf38 into nrwl:master Apr 10, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

@Coly010 Coly010 Coly010 approved these changes

@StalkAltan StalkAltan Awaiting requested review from StalkAltan StalkAltan is a code owner

@rarmatei rarmatei Awaiting requested review from rarmatei rarmatei is a code owner

@jaysoo jaysoo Awaiting requested review from jaysoo jaysoo is a code owner automatically assigned from nrwl/nx-testing-tools-reviewers

@Cammisuli Cammisuli Awaiting requested review from Cammisuli Cammisuli is a code owner automatically assigned from nrwl/nx-core-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FrozenPandaz @AgentEnder @Coly010