feat(core): improve checks for process.env.CI #22694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f063626. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
luckened
requested review from
FrozenPandaz,
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
luckened
changed the title
luckened
changed the title
AgentEnder
requested changes
Apr 5, 2024
luckened
force-pushed
the
patch-1
branch
2 times, most recently
from
a41b94a
to
23d2f26
Compare
|
@AgentEnder thank you for the review!
done 👍 |
luckened
force-pushed
the
patch-1
branch
6 times, most recently
from
22106e3
to
34688ae
Compare
luckened
changed the title
luckened
force-pushed
the
patch-1
branch
4 times, most recently
from
ab38675
to
851acc5
Compare
luckened
force-pushed
the
patch-1
branch
5 times, most recently
from
23836b1
to
a3b0874
Compare
AgentEnder
approved these changes
Apr 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Today, nx does not disable the output styling and WoodpeckerCI doesn't go well with it, This requires us to manually add "output-style=stream" to every nx command, which solves the issue but I understand that we could have a woodpecker check to isCI function as well
reference:
https://woodpecker-ci.org/docs/usage/environment#built-in-environment-variables
Expected Behavior
Disable styling in nx command outputs when running in WoodpeckerCI
Related Issue(s)
I haven't found a related issue, but this PR came as a suggestion in this discord thread: https://discord.com/channels/1143497901675401286/1225808236104646706
@ edit
the title is "feat(core): add WoodpeckerCI to isCI check" but the check also applies to other CI vendors that set process.env.CI to a non-empty string
@ edit2
I've improved the PR title with feat(core): improve checks for process.env.CI since it now covers all CI players that dont'set process.env.CI directly to "true" but to other values instead