Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): Should work when absolute paths are supplied as output #22736

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ndcunningham
Copy link
Contributor

When an output path is supplied to NxWebpack

module.exports = {
  output: {
    path: join(__dirname, '../../dist/apps/acme'),
  },
  //etc....
}

When running serve using webpack plugin fails to find because the path generated will look something like

{workspaceRoot}/../../../../private/{path-to-project}/my-project/dist/apps/acme

This path needs to be resolved before attempting to serve.

@ndcunningham ndcunningham self-assigned this Apr 9, 2024
@ndcunningham ndcunningham requested review from a team as code owners April 9, 2024 00:36
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 3:11pm

@ndcunningham ndcunningham force-pushed the fix/nest-webpack-serve branch 2 times, most recently from 1ed7fa4 to 4b97fa4 Compare April 9, 2024 09:35
@ndcunningham ndcunningham merged commit c27a668 into master Apr 9, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/nest-webpack-serve branch April 9, 2024 15:27
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants