Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support finding matching projects with only negative patterns #22743

Merged
merged 1 commit into from
May 13, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

Passing --projects !tag:someTag would select 0 projects, since the only pattern is negative

Expected Behavior

Passing --projects !tag:someTag would select X projects, where X is the number of projects without someTag.

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner April 9, 2024 14:24
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 2:25pm

@FrozenPandaz FrozenPandaz merged commit 8975786 into nrwl:master May 13, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request May 14, 2024
…erns (#22743)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
Passing `--projects !tag:someTag` would select 0 projects, since the
only pattern is negative

## Expected Behavior
Passing `--projects !tag:someTag` would select X projects, where X is
the number of projects without someTag.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 8975786)
AgentEnder added a commit that referenced this pull request May 16, 2024
FrozenPandaz pushed a commit that referenced this pull request May 16, 2024
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants