Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): detect imports from template literals in dynamic imports #22749

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Code such as the following does not yield dependencies:

require(`my-module`);
import(`my-module`);

Expected Behavior

The above code does yield dependencies.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 5:38pm

@FrozenPandaz FrozenPandaz changed the title feat(core): detect imports from template literals in dynamic imports fix(core): detect imports from template literals in dynamic imports Apr 9, 2024
@FrozenPandaz FrozenPandaz marked this pull request as ready for review April 9, 2024 19:49
@FrozenPandaz FrozenPandaz requested review from a team as code owners April 9, 2024 19:49
@FrozenPandaz FrozenPandaz merged commit afdd37a into nrwl:master Apr 9, 2024
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants