feat(testing): add playwright generator to convert from executors to plugin #22784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Coly010
changed the title
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7760f69. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
46fe18e
to
4f03836
Compare
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
3a6fb21
to
cf01c5b
Compare
Coly010
changed the title
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
1560703
to
04b04de
Compare
FrozenPandaz
requested changes
Apr 18, 2024
packages/devkit/src/generators/plugin-migrations/plugin-migration-utils.ts
Outdated
Show resolved
Hide resolved
packages/devkit/src/generators/plugin-migrations/plugin-migration-utils.ts
Outdated
Show resolved
Hide resolved
packages/playwright/src/generators/convert-to-inferred/lib/migrate-executor-to-plugin.ts
Outdated
Show resolved
Hide resolved
packages/playwright/src/generators/convert-to-inferred/convert-to-inferred.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
04b04de
to
48d73af
Compare
Coly010
force-pushed
the
playwright/crystal-migration
branch
2 times, most recently
from
2871cbe
to
0bbebe7
Compare
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
0bbebe7
to
f1c191a
Compare
Coly010
force-pushed
the
playwright/crystal-migration
branch
2 times, most recently
from
fe4846f
to
e93a517
Compare
FrozenPandaz
requested changes
Apr 19, 2024
packages/playwright/src/generators/convert-to-inferred/convert-to-inferred.ts
Outdated
Show resolved
Hide resolved
packages/devkit/src/generators/plugin-migrations/plugin-migration-utils.ts
Outdated
Show resolved
Hide resolved
packages/devkit/src/generators/plugin-migrations/plugin-migration-utils.ts
Outdated
Show resolved
Hide resolved
packages/devkit/src/generators/plugin-migrations/plugin-migration-utils.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
fd36d3e
to
c7c5e57
Compare
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
c7c5e57
to
3dcb61a
Compare
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
3dcb61a
to
e3e516a
Compare
Coly010
force-pushed
the
playwright/crystal-migration
branch
from
8bc2fd1
to
7760f69
Compare
isaacplmann
approved these changes
Apr 24, 2024
FrozenPandaz
approved these changes
Apr 24, 2024
Comment on lines
19
to
29
| const migrator = new ExecutorToPluginMigrator<PlaywrightPluginOptions>( | ||
| tree, | ||
| projectGraph, | ||
| '@nx/playwright:playwright', | ||
| '@nx/playwright/plugin', | ||
| (targetName) => ({ targetName, ciTargetName: 'e2e-ci' }), | ||
| postTargetTransformer, | ||
| createNodes, | ||
| options.project | ||
| ); | ||
| await migrator.run(); |
There was a problem hiding this comment.
Export a function that does this.
| return createdTarget; | ||
| } | ||
|
|
||
| async #getCreateNodesResults() { |
There was a problem hiding this comment.
Use
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The only way to migrate a project from playwright executor usage to playwright plugin usage is to do so manually.
Expected Behavior
Add a generator that will convert projects from playwright executor usage to playwright plugin usage
Usage
nx g @nx/playwright:convert-to-inferred --project="myapp-e2e"// Convert onlymyapp-e2efrom executor to plugin usagenx g @nx/playwright:convert-to-inferred// Migrate all projectsRelated Issue(s)
Fixes #