Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): new main navigation menu #22829

Merged
merged 13 commits into from
Apr 18, 2024
Merged

feat(nx-dev): new main navigation menu #22829

merged 13 commits into from
Apr 18, 2024

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Apr 15, 2024

It adds a new main navigation menu on the website and in the documentation, offering more choices and simpler access to different parts of the content for the visitor.

@ndcunningham ndcunningham self-assigned this Apr 15, 2024
Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 18, 2024 2:20pm

@ndcunningham ndcunningham force-pushed the feat/nx-dev-nav-update branch 2 times, most recently from 745d19b to 921cec1 Compare April 17, 2024 14:52
@bcabanes bcabanes force-pushed the feat/nx-dev-nav-update branch 2 times, most recently from bcc6a1a to 6cf6e6c Compare April 17, 2024 21:02
@bcabanes bcabanes marked this pull request as ready for review April 17, 2024 21:17
@bcabanes bcabanes requested review from FrozenPandaz, vsavkin and a team as code owners April 17, 2024 21:17
@bcabanes bcabanes changed the title feat(nx-dev): Update nx-dev navigation menu feat(nx-dev): new main navigation menu Apr 17, 2024
ndcunningham and others added 13 commits April 18, 2024 10:19
Updates the navigation menus on mobile and desktop as well as on the website and the documentation. It also does some code markup cleanup.
It fixes the `prettier-plugin-tailwindcss` plugin to actually make it work, updates the dependencies related to prettier and run `nx format:write`.
A typo in the name of a menu item was corrected from 'Code exmaple for your stack' to 'Code examples for your stack'.
- It now works on lg breakpoint
- Update width to be 1x smaller
@bcabanes bcabanes enabled auto-merge (squash) April 18, 2024 14:47
Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcabanes bcabanes disabled auto-merge April 18, 2024 15:23
@bcabanes bcabanes merged commit 4d6cd36 into master Apr 18, 2024
6 checks passed
@bcabanes bcabanes deleted the feat/nx-dev-nav-update branch April 18, 2024 15:24
AgentEnder pushed a commit to AgentEnder/nx that referenced this pull request Apr 23, 2024
It adds a new main navigation menu on the website and in the documentation, offering more choices and simpler access to different parts of the content for the visitor.

Co-authored-by: Benjamin Cabanes <3447705+bcabanes@users.noreply.github.com>
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants