Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): different commands should not be considered compatible targets #22863

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

A sm typo causes isCompatibleTarget to read incorrectly

Expected Behavior

isCompatibleTarget is false if commands vary

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner April 17, 2024 22:04
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 20, 2024 2:06am

@AgentEnder AgentEnder force-pushed the fix/commands-compatible-targets branch 2 times, most recently from 3465ae4 to e609bad Compare April 19, 2024 20:57
@AgentEnder AgentEnder force-pushed the fix/commands-compatible-targets branch from e609bad to 2be50e5 Compare April 19, 2024 21:35
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) April 19, 2024 22:01
@AgentEnder AgentEnder requested a review from a team as a code owner April 20, 2024 00:02
@AgentEnder AgentEnder force-pushed the fix/commands-compatible-targets branch 3 times, most recently from 1214a71 to b555f70 Compare April 20, 2024 00:18
@AgentEnder AgentEnder force-pushed the fix/commands-compatible-targets branch from b555f70 to b7e048f Compare April 20, 2024 02:05
@FrozenPandaz FrozenPandaz merged commit c49c07d into nrwl:master Apr 20, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Apr 23, 2024
AgentEnder added a commit to AgentEnder/nx that referenced this pull request Apr 23, 2024
Copy link

github-actions bot commented May 2, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants