Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add support for pnpm lockfile v9 #22906

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Apr 19, 2024

  • Fix parenthesis separator detection
  • Fix leading dash detection
  • Migrate existing pnpm normalizer to latest code
  • Add unit tests for v9
  • Dogfooding Pnpm v9 to Nx repo and agents

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #22850

@meeroslav meeroslav self-assigned this Apr 19, 2024
@meeroslav meeroslav requested a review from a team as a code owner April 19, 2024 12:10
Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 3:17pm

Copy link

nx-cloud bot commented Apr 19, 2024

☁️ Nx Cloud Report

CI is running for commit d81af51.

📂 Click to track the progress, see the status, the terminal output, and the build insights.


Sent with 💌 from NxCloud.

@mattfysh
Copy link

great work @meeroslav ! would it also be useful to raise an error if the lockfileVersion encountered is outside the expected range?

binary64 added a commit to binary64/blabber that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production built app's package.json dependencies are empty with pnpm@9
2 participants