Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix exclude for empty array #22951

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Globbing with an excludes array which is empty yields every file being excluded.

Expected Behavior

Globbing with an excludes array which is empty yields no file being excluded.

Related Issue(s)

Fixes #

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 2:31am

@FrozenPandaz FrozenPandaz marked this pull request as ready for review April 23, 2024 03:30
@FrozenPandaz FrozenPandaz requested review from a team as code owners April 23, 2024 03:30
@FrozenPandaz FrozenPandaz enabled auto-merge (squash) April 23, 2024 03:53
@FrozenPandaz FrozenPandaz merged commit 8ded380 into nrwl:master Apr 23, 2024
6 checks passed
AgentEnder pushed a commit to AgentEnder/nx that referenced this pull request Apr 23, 2024
FrozenPandaz added a commit that referenced this pull request Apr 25, 2024
Copy link

github-actions bot commented May 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants