Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): handle inherited config correctly when identifying the framework used for inferred tasks #22953

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 23, 2024

Current Behavior

When inferring Storybook tasks and identifying the framework used in the Storybook configuration, the project .storybook/main.{js|ts} file is scanned using AST to get the framework property. This doesn't account for the framework to have been defined in a base/parent configuration file that's merged into the project Storybook configuration. Therefore, the framework is not correctly identified in such cases.

Expected Behavior

When inferring Storybook tasks, the framework should be correctly identified regardless of where it was defined (project config or base/parent config).

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 23, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner April 23, 2024 11:58
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 0:00am

@FrozenPandaz FrozenPandaz merged commit 6cab4c9 into nrwl:master Apr 23, 2024
6 checks passed
FrozenPandaz pushed a commit that referenced this pull request Apr 25, 2024
…e framework used for inferred tasks (#22953)

(cherry picked from commit 6cab4c9)
Copy link

github-actions bot commented May 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
@leosvelperez leosvelperez deleted the storybook/plugin-identify-fwk-correctly branch May 8, 2024 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants