fix(gradle): change gradle command to be relative path #22963
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 00b8df0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
| ) { | ||
| const gradleBinaryPath = getGradleBinaryPath(); | ||
| const graldeFile = getGradleFile(); |
There was a problem hiding this comment.
| const graldeFile = getGradleFile(); | |
| const gradleFile = getGradleFile(); |
packages/gradle/src/plugin/nodes.ts
Outdated
| options: { | ||
| cwd: projectRoot, | ||
| cwd: workspaceRoot, |
There was a problem hiding this comment.
Can we keep projectRoot and get a relative path from projectRoot to gradleFile?
Moving to the workspaceRoot would break the command for nested projects.
xiongemi
force-pushed
the
feature/nxc-592-use-relative-path-for-gradle-command
branch
4 times, most recently
from
06d0221
to
2333ce3
Compare
| if (!existsSync(gradleBinaryPath)) { | ||
| throw new Error('Gradle is not setup. Run "gradle init"'); | ||
| } |
There was a problem hiding this comment.
I don't think there was anything wrong this. Can you bring it back please?
There was a problem hiding this comment.
this check is a part of getGradleBinaryPath function, which got called before this line. i don't think we need this
xiongemi
force-pushed
the
feature/nxc-592-use-relative-path-for-gradle-command
branch
from
2333ce3
to
00b8df0
Compare
(cherry picked from commit 99e5c86)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #