Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): regression register ts transpiler for local plugin #22964

Merged

Conversation

Roozenboom
Copy link
Contributor

This change solves a regression after #22527 in NX 18.3.x with registering the ts transpiler for local plugins.

In the deleted file packages/nx/src/utils/nx-plugin.ts the method registerPluginTSTranspiler was called on line 461 1f04cde#diff-4cb86fce6ea77ce0e318878f99d35ca09197cd67f2b4024a996d41bba47d3ea2L460-L462

This part was missing in the replacement file packages/nx/src/project-graph/plugins/loader.ts around line 120
https://github.com/nrwl/nx/pull/22527/files#diff-42e02f59c2df8000df3ad944ae8a5d21b25c9593087666c8e6577cce2b17faecR120

Current Behavior

ts transpiler is not registered for local plugin generators that use a directory structure with index.ts

Screenshot 2024-04-23 at 16 37 06

Expected Behavior

The ts transpiler is registered for local plugins

Related Issue(s)

Fixes #22958

@Roozenboom Roozenboom requested a review from a team as a code owner April 23, 2024 19:59
Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 8:51pm

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @Roozenboom... Can you move the implementation to inside readPluginPackageJson? We already register the transpiler correctly in other cases.

@Roozenboom
Copy link
Contributor Author

Good catch @Roozenboom... Can you move the implementation to inside readPluginPackageJson? We already register the transpiler correctly in other cases.

Hi @AgentEnder, I updated the PR and moved the implementation to readPluginPackageJson. Please let me know if this is ok like this.

@AgentEnder AgentEnder merged commit abaad32 into nrwl:master Apr 23, 2024
6 checks passed
@Roozenboom Roozenboom deleted the bugfix/register-plugin-ts-transpiler branch April 24, 2024 06:46
FrozenPandaz pushed a commit that referenced this pull request Apr 25, 2024
Copy link

github-actions bot commented May 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local nx plugin generator TypeScript transpiler not loaded in NX 18.3.x
2 participants