Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): nxComponentTestingPreset should not expose bundler option #23009

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented Apr 25, 2024

When using nxComponentTestingPreset after the configuration has been created for your e2e project, you should not be able to use the bundler option to change to a new bundler.

The project will need to be reconfigured for the new bundler.

fixes: #23008

@ndcunningham ndcunningham added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Apr 25, 2024
@ndcunningham ndcunningham self-assigned this Apr 25, 2024
@ndcunningham ndcunningham requested review from a team as code owners April 25, 2024 16:34
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2024 4:35pm

@Coly010 Coly010 merged commit 49af691 into master Apr 26, 2024
7 checks passed
@Coly010 Coly010 deleted the fix/cypress-preset-component-testing branch April 26, 2024 08:31
Copy link

github-actions bot commented May 2, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress component tests - Vite isn't used instead of webpack
3 participants