Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): do not infer a test-storybook task if @storybook/test-runner is not installed #23034

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 26, 2024

Current Behavior

@nx/storybook/plugin always infers a test-storybook task with the @storybook/test-runner included in the externalDependencies. It doesn't check whether the package is actually installed, which causes the hasher to fail with The externalDependency '@storybook/test-runner' for '<project>:test-storybook' could not be found.

Expected Behavior

@nx/storybook/plugin should only infer a test-storybook task when the @storybook/test-runner package is installed.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 26, 2024
@leosvelperez leosvelperez requested a review from a team as a code owner April 26, 2024 12:36
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 0:38am

@leosvelperez leosvelperez enabled auto-merge (squash) April 26, 2024 13:10
@leosvelperez leosvelperez merged commit 9077ae8 into nrwl:master Apr 26, 2024
6 checks passed
@leosvelperez leosvelperez deleted the storybook/invalid-test-target branch April 27, 2024 12:58
Copy link

github-actions bot commented May 3, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants