Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): ignore yarn corepack check when updating config #23043

Merged
merged 1 commit into from Apr 26, 2024

Conversation

AgentEnder
Copy link
Member

Current Behavior

Repositories with packageManager set to anything except a valid yarn version will face issues when trying to start the local registry via our verdaccio executor.

Expected Behavior

We can pass SKIP_YARN_COREPACK_CHECK in the env when running commands as part of the verdaccio executor to avoid this issue. We are only ever reading / mutating yarn configs, so its safe in this instance.

Related Issue(s)

Fixes #

@AgentEnder AgentEnder requested a review from a team as a code owner April 26, 2024 21:39
Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 9:42pm

@FrozenPandaz FrozenPandaz enabled auto-merge (squash) April 26, 2024 22:24
@FrozenPandaz FrozenPandaz merged commit c5df990 into nrwl:master Apr 26, 2024
6 checks passed
Copy link

github-actions bot commented May 2, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants