Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Boolean flags do not need a value #23072

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

ndcunningham
Copy link
Contributor

Boolean options passed to the next-cli as arguments should not require a value.

So --profile=true will not work with Next.js v14.2.0+. However --profile works on both the current and future versions.

closes: #23062

@ndcunningham ndcunningham self-assigned this Apr 29, 2024
@ndcunningham ndcunningham requested a review from a team as a code owner April 29, 2024 15:14
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 29, 2024 3:14pm

@ndcunningham ndcunningham merged commit 24f6d38 into master Apr 29, 2024
6 checks passed
@ndcunningham ndcunningham deleted the fix/next-options branch April 29, 2024 16:24
Copy link

github-actions bot commented May 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using @nx/next:executors fail nextjs cli commands with error: unknown option
2 participants