Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): typescript plugin target hashing #23073

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

JamesHenry
Copy link
Collaborator

Current Behavior

Different targets (typecheck vs build) can clobber each other within the cache, leading to missing targets

Expected Behavior

Targets are cached based on a combination of node hash and config file path

Related Issue(s)

Fixes #

@JamesHenry JamesHenry requested a review from a team as a code owner April 29, 2024 15:28
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 3:30pm

@JamesHenry JamesHenry enabled auto-merge (squash) April 29, 2024 15:28
@JamesHenry JamesHenry merged commit addde70 into nrwl:master Apr 29, 2024
6 checks passed
@JamesHenry JamesHenry deleted the ts-hash-fix branch April 29, 2024 17:53
Copy link

github-actions bot commented May 5, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants